Skip to content

Update return of vm_snapshot_attach_disk module. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 16, 2023
Merged

Update return of vm_snapshot_attach_disk module. #234

merged 7 commits into from
May 16, 2023

Conversation

@anazobec
Copy link
Collaborator

@anazobec anazobec commented May 16, 2023

A small change to vm_snapshot_attach_disk was made as requested in #233.

  • add vm_rebooted status to return --> info if reboot of the destination VM was performed.

@anazobec anazobec self-assigned this May 16, 2023
@anazobec anazobec requested a review from justinc1 May 16, 2023 13:02
justinc1 added 4 commits May 16, 2023 16:45
@justinc1
Use VM .reboot to detect if VM reboot was needed
72c5f6a 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Test vm_rebooted return value
52d3ddf 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Test returned record
72530d2 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Test returned record is consistent with data from vm_info
0b60ff2 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Copy link
Collaborator

justinc1 commented May 16, 2023

I modified code a bit (VM.reboot already contained status if VM was rebooted). Extra changes were in integration tests - now we will test also what is in returned record, and if returned record does match what vm_info module returns.

@justinc1
Update unit tests
dc58c0d 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
justinc1 approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ok

@justinc1
format
6f7da9c 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 merged commit 621a841 into main May 16, 2023
@justinc1 justinc1 deleted the vm-snapshot-attach-disk-return-update branch May 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinc1 justinc1 justinc1 approved these changes

Assignees

@anazobec anazobec

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anazobec @justinc1